Skip to content

Add a new method to benchmarks: DoubleEnsemble - #286

Merged
you-n-g merged 12 commits into
microsoft:mainfrom
meng-ustc:main
Mar 2, 2021
Merged

Add a new method to benchmarks: DoubleEnsemble#286
you-n-g merged 12 commits into
microsoft:mainfrom
meng-ustc:main

Conversation

@meng-ustc

Copy link
Copy Markdown
Contributor

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation
@ghost

Deleted user (ghost) commented Feb 24, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@Derek-Wds Derek Wang (Derek-Wds) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

Please sign the Contributor License Agreement.
Screenshot from 2021-02-23 17-04-39

Comment thread README.md
- [SFM based on pytorch (Liheng Zhang, et al. 2017)](qlib/contrib/model/pytorch_sfm.py)
- [TFT based on tensorflow (Bryan Lim, et al. 2019)](examples/benchmarks/TFT/tft.py)
- [TabNet based on pytorch (Sercan O. Arik, et al. 2019)](qlib/contrib/model/pytorch_tabnet.py)
- [DoubleEnsemble based on LightGBM (Chuheng Zhang, et al. 2020)](qlib/contrib/model/double_ensemble.py)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your model results here ?
https://github.com/microsoft/qlib/tree/main/examples/benchmarks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results are up to date now.

Comment thread qlib/contrib/model/double_ensemble.py Outdated
**kwargs
):
self.base = base # "gbm" or "mlp", specifically, we use lgbm for "gbm"
self.k = k

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give more details about the parameters.
Give it a full name at least

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. The new names are "base_model" and "num_models".

@you-n-g

you-n-g commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

Meng Dong (@meng-ustc)
It looks great. Thanks for your great efforts :)

@you-n-g
you-n-g merged commit 0bcaab3 into microsoft:main Mar 2, 2021
you-n-g pushed a commit to you-n-g/qlib that referenced this pull request Aug 16, 2025
gen gao (gaogen123) pushed a commit to gaogen123/qlib that referenced this pull request Sep 13, 2025
Add a new method to benchmarks: DoubleEnsemble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants