Upgrade Flow to 0.329.0 - #3845
Open
mwiencek wants to merge 8 commits into
Open
Conversation
https://github.com/facebook/flow/releases/tag/v0.328.0 All `ignore` patterns are relative to the project root. `<PROJECT_ROOT>` and absolute paths like /Volumes are now an error.
https://github.com/facebook/flow/releases/tag/v0.329.0 The main breaking change affecting us is "Flow will error on legacy variance syntax in library definition files." The flow-typed/environment libdefs are not updated in flow-typed repository yet, but there appear to be fixed copies maintained separately in the Flow repository, which I've copied here: https://github.com/facebook/flow/tree/main/evals/flow-typed/environment These have a copyright header referencing a nonexistent LICENSE file which I'll fix in the next commit. The rest of the libdefs I updated by hand.
The files as synced from the flow-typed command did not contain any copyright header. The ones I copied from https://github.com/facebook/flow/tree/main/evals/flow-typed/environment in the previous commit do. This adds their license to the same directory.
https://flow.org/en/docs/tools/eslint/ now recommends flow-eslint. eslint-plugin-ft-flow requires hermes-eslint as a peer dependency, but this only causes a warning when running `yarn`. The plugin itself seems to work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Flow is outdated. I've been having issues with the previous version using up all of my system's memory and crashing.
Solution
Upgrades Flow to the latest version.
AI usage
None.
Testing
Just
./node_modules/.bin/flow.