Repository navigation
Conversation
Types-only upgrade, no source change needed. Emitted JS and .d.ts of both plugins are unchanged, and so is the JSON-LD output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
pr: dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.4 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.4 MB ℹ️ View Unchanged
|
|
The linked issue is now fixed, good catch! |
…ency) (AI-assisted) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
removed
the
status: blocked
slorber
marked this pull request as ready for review
October 10, 2026 12:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Upgrade
schema-dtsfrom^1.1.5to^2.1.0in@docusaurus/plugin-content-blogand@docusaurus/plugin-content-docs(v2.0.0 release notes). We need 2.1.0: it depends onschema-dts-lib@^1.1.0, which dropped the requiredtypescriptpeer dependency ofschema-dts-lib@1.0.0(google/schema-dts#225). Otherwise, npm/pnpm would install TypeScript in JS-only sites.No source change needed: our JSON-LD objects (
Blog,BlogPosting,Person,ImageObject,BreadcrumbList,WithContext) typecheck as-is with v2.It stays in
dependencies: the types are part of the public client API.useBlogPostStructuredData(),useBlogListPageStructuredData()(@docusaurus/plugin-content-blog/client) anduseBreadcrumbsStructuredData()(@docusaurus/plugin-content-docs/client) returnWithContext<...>types, and the publishedlib/client/structuredDataUtils.d.tsimports from'schema-dts'.User-facing changes
.d.tsis identical), but the referenced types now follow Schema.org v30. Compared with v1, they add optional properties (owner,displayLocation,wordCount,pronouns...) and widen a few property types (genre,owns,hasCredential,weight,duration).Duration/Massare now plain strings, because Schema.org madeQuantitya DataType.schema-dts@1: v1 and v2 types aren't mutually assignable. Sites that annotate the hooks' return values with types from their ownschema-dts@1install must upgrade it to v2.Test Plan
lib/(.js+.d.ts) is byte-identical tomain.build:website:fast) onmainand on this branch and extracted every<script type="application/ld+json">block (257 blocks across 988 pages: 13Blog, 49BlogPosting, 195BreadcrumbList). They are identical.skipLibCheck: false, whose program includesschema-dtsandschema-dts-lib;classic-typescripttemplate, plus a temporary probe calling all 3 hooks (also checked undernodenext).pnpm test,lint:js,lint:knip,lint:deps.schema-dts@2.1.0andschema-dts-lib@1.1.0with notypescriptpeer; website typecheck,pnpm testandlint:depspass.Test links
Deploy preview: https://deploy-preview-12568--docusaurus-2.netlify.app/
BlogPosting: https://deploy-preview-12568--docusaurus-2.netlify.app/blog/releases/3.0Blog: https://deploy-preview-12568--docusaurus-2.netlify.app/blogBreadcrumbList: https://deploy-preview-12568--docusaurus-2.netlify.app/docs/api/plugins/@docusaurus/plugin-content-docsRelated issues/PRs
🤖 Generated with Claude Code