Skip to content

fix(cli): honor an explicitly empty string input - #4113

Merged
UziTech merged 1 commit into
markedjs:masterfrom
xu91102:fix/cli-empty-string
Oct 6, 2026
Merged

UziTech merged 1 commit into
markedjs:masterfrom
xu91102:fix/cli-empty-string

Conversation

@xu91102

@xu91102 xu91102 commented Sep 26, 2026

Copy link
Copy Markdown

Marked version: 18.0.14 / ef0704c58459e927c805b92a5cc7d0c629e6fe43

Markdown flavor: n/a (CLI input selection)

Description

Fixes #4112.

Treat --string '' as explicitly supplied input. The previous truthiness check fell through to stdin (or a file), so piping unrelated content into the command rendered that content, and interactive use waited for input. Nonempty strings and omitted --string retain their behavior.

Added a CLI regression with an empty string and nonempty stdin. It fails before the fix and passes after the one-line change. Also verified the real CLI with a child process.

Validation: npm test passed, including 1,861 specification tests, 193 unit tests, UMD/CJS checks, type checks, and ESLint. No generated files are included. Assisted by Codex; reviewed the complete diff and ran the checks locally on macOS.

Contributor

  • Test(s) exist to ensure functionality and minimize regression.
  • No tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places. (Bug fix, no new feature.)

Committer

  • CI is green (no forced merge required).
  • Squash and Merge PR following conventional commit guidelines.
@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the MarkedJS Team on Vercel.

A member of the Team first needs to authorize it.

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
marked-website Ready Ready Preview Sep 26, 2026 7:18pm UTC

Request Review

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech
UziTech merged commit ec3a4e5 into markedjs:master Oct 6, 2026
8 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 12, 2026
## [18.1.1](v18.1.0...v18.1.1) (2026-10-12)

### Bug Fixes

* **cli:** honor an explicitly empty string input ([#4113](#4113)) ([ec3a4e5](ec3a4e5))
* end blockquote before a lazy line after a heading, hr or html block ([#4115](#4115)) ([9e64a6a](9e64a6a))
* keep a backslash in a code span from hiding emphasis ([#4117](#4117)) ([6a57018](6a57018))
* keep a decoded character reference from forming a new one ([#4111](#4111)) ([6bbac0c](6bbac0c)), closes [#38](#38) [#112](#112)
* let indented and type 3-5 html blocks interrupt a paragraph ([#4124](#4124)) ([eaa1fff](eaa1fff))
* make walkTokens linear by appending values in place ([#4121](#4121)) ([627d9ae](627d9ae)), closes [#4120](#4120)
* match pre, script, style and textarea as whole tag names ([#4114](#4114)) ([0db74cb](0db74cb))
* preserve enclosing link state after parsing images ([#4123](#4123)) ([cc07bb9](cc07bb9))
* respect tab stops in list continuation indentation ([#4119](#4119)) ([4bd2528](4bd2528))

### Performance Improvements

* avoid repeated raw string copies in nested lists ([#4082](#4082)) ([7e8754d](7e8754d))

This branch was successfully deployed

1 active deployment
Preview — 3383a39d Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants