Add white outline to black emojis - #258
Open
pelya wants to merge 3 commits into
Open
Conversation
You can check which emojis look poorly on the dark background by changing color scheme in your browser settings
Images that are partially black, such as ninja, are not modified
Contributor
|
You should propose this for the individual emoji providers. This repository merely aggregates them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some emoji images are fully black, which makes them invisible in chat reactions in Signal messenger when dark display theme is used. This PR adds a while outline for these emojis, so they are visible with both light and dark display themes.
Screenshots before:
Screenshots after:
By the way, this repository is used by Signal messenger, with Apple image data used for Apple, Android, and PC app.