fix #585: Dialog's top message can be undefined#611
Open
baumschubser wants to merge 1 commit intogram-js:masterfrom
Open
fix #585: Dialog's top message can be undefined#611baumschubser wants to merge 1 commit intogram-js:masterfrom
baumschubser wants to merge 1 commit intogram-js:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585 by making Dialog's
dateproperty optional. This prop is the dialog's "top message" date and since that can be undefined, the date can be undefined, too.With this change, I can use getDialogs and do not experience any unwanted side effects.