fix: handle QuickTime wave/esds in mp4a codec derivation and fragmented init#550
Open
fix: handle QuickTime wave/esds in mp4a codec derivation and fragmented init#550
Conversation
e3642e6 to
514dbf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed some QT files were producing incomplete/incorrect audio codec strings and compatibility issues in my fragmented playback flows.
This PR improves handling of QuickTime-style audio sample entries in QT files where codec/config metadata is nested under
wave.esdsrather than exposed directly on the sample entry.The underlying issue was about how
mp4asample entries can be structured in QuickTime files:mp4a.wave.esdsinstead ofmp4a.esds.This has two main issues:
mp4arelies on directesdswave.esdslayouts fails to give the correct codec string.wave.esds. The MSE apis expects init segments to have directesds.What changed
mp4acodec derivation now supports nested QuickTime layoutmp4aentries, codec derivation now resolves descriptor info from:esdswave.esdsmp4a.wave.esdslayoutswriteInitializationSegment(...),mp4aentries with nestedwave.esdsare normalized to directesdsrepresentation.