Skip to content

Support multiple -add_comment arguments - #987

Open
camillobruni wants to merge 2 commits into
google:mainfrom
camillobruni:2026-01-15_multiple_add_comment
Open

Support multiple -add_comment arguments#987
camillobruni wants to merge 2 commits into
google:mainfrom
camillobruni:2026-01-15_multiple_add_comment

Conversation

@camillobruni

Copy link
Copy Markdown

This makes it a bit nicer to annotate profiles when using external tools.

@codecov-commenter

codecov-commenter commented Jan 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.35%. Comparing base (294ebfa) to head (282fd68).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   67.35%   67.35%           
=======================================
  Files          44       44           
  Lines        7792     7792           
=======================================
  Hits         5248     5248           
  Misses       2112     2112           
  Partials      432      432           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aalexand aalexand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test implementation testFlags is different from internal/driver/flags.go. I'm not sure GoFlags there support multiple flags properly. Could you test that manually? Please also check that this change does not make the comma a separator as we want something like -add_comment=hello,world to add one comment, not two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants