Repository navigation
Migrate existing regular expression checks to RegexMatchers. - #6262
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Replace duplicated regular expression class-name strings and method matchers in `AbstractPatternSyntaxChecker`, `InvalidPatternSyntax`, `StringSplitter`, `JdkObsolete`, `UnnecessarySetDefault`, `WellKnownMutability`, and `ConstantExpressions` with shared definitions from `RegexMatchers`. Using `NON_CLOSEABLE_PATTERN_CLASSES` also records `org.safere.Pattern` as immutable in `WellKnownMutability` and treats static factory methods on `com.google.re2j.Pattern` and `org.safere.Pattern` as pure in `ConstantExpressions`. PiperOrigin-RevId: 1009639525
copybara-service
Bot
force-pushed
the
test_1009639525
branch
from
October 30, 2026 09:35
b051ae0 to
dd9bdee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate existing regular expression checks to RegexMatchers.
Replace duplicated regular expression class-name strings and method matchers in
AbstractPatternSyntaxChecker,InvalidPatternSyntax,StringSplitter,JdkObsolete,UnnecessarySetDefault,WellKnownMutability, andConstantExpressionswith shared definitions fromRegexMatchers. UsingNON_CLOSEABLE_PATTERN_CLASSESalso recordsorg.safere.Patternas immutable inWellKnownMutabilityand treats static factory methods oncom.google.re2j.Patternandorg.safere.Patternas pure inConstantExpressions.