Repository navigation
Enforce @MustBeClosed on method and constructor references. - #6259
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
MustBeClosedChecker only checked method invocations and constructor calls, so passing a reference to a `@MustBeClosed` method or constructor (such as `foo::mustBeClosedMethod` or `MustBeClosedResource::new`) to a functional interface whose method is not annotated with `@MustBeClosed` (such as `Supplier<Closeable>`) bypassed the check and let the resource leak. Method and constructor references are now checked like lambdas: they are reported unless the functional interface method is annotated with `@MustBeClosed`. As with lambdas, references passed to exception-testing APIs such as `assertThrows` are exempt. StreamResourceLeak shares this logic, so it now also reports references such as `Files::lines`. The new behavior can be disabled with `-XepOpt:MustBeClosedChecker:MatchMethodReferences=false`. PiperOrigin-RevId: 1009886326
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce @MustBeClosed on method and constructor references.
MustBeClosedChecker only checked method invocations and constructor calls, so
passing a reference to a
@MustBeClosedmethod or constructor (such asfoo::mustBeClosedMethodorMustBeClosedResource::new) to a functionalinterface whose method is not annotated with
@MustBeClosed(such asSupplier<Closeable>) bypassed the check and let the resource leak.Method and constructor references are now checked like lambdas: they are
reported unless the functional interface method is annotated with
@MustBeClosed. As with lambdas, references passed to exception-testing APIssuch as
assertThrowsare exempt. StreamResourceLeak shares this logic, so itnow also reports references such as
Files::lines. The new behavior can bedisabled with
-XepOpt:MustBeClosedChecker:MatchMethodReferences=false.