Repository navigation
web: enable Danish (da-DK) locale - #26776
Open
asbjoern-navio wants to merge 1 commit into
Open
asbjoern-navio wants to merge 1 commit into
asbjoern-navio wants to merge 1 commit into
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
What does this PR change?
Sets
ship: trueforda-DKinlocales.yamland regenerates the outputs:make gen-localesupdatesweb/lit-localize.jsonandweb/src/common/ui/locale/definitions.ts..github/transifex.ymlalready mapsda_DK: da-DK.web/src/locale-codes.ts.Why is this change needed?
Danish is fully translated on Transifex, save for strings that have been added in the past few weeks - about 98% translated as of this PR. Both catalogs are already in the tree:
web/xliff/da-DK.xlf(renamed in #26735) andlocale/da_DK/(#26340, compiled in #26364). The registry still had Danish atship: false, carried over from the #24563 inventory, where it stood at 0.6%.How was this tested?
make ci-lint-locales,make web-checkandmake web-check-compilepass.make test authentik/root/tests/test_locales.pypasses, including Danish intest_shipped_catalogs_load.pnpm --dir web run build-localescompilesda-DK. Its 48 missing strings were added upstream while Danish was unshipped; the extract bot fills them in after merge.Linked issues
refs #24563. This follows the registry process from #26735, the same way #24788 enabled Bengali.
AI disclosure
The Danish translations were drafted with Claude Code (Anthropic's Claude) against a glossary I set, and I reviewed and edited a calibration batch and verified a QA report before uploading them to Transifex. I am a native Danish speaker. This PR's change was also made with assistance from Claude Code, but human-reviewed and edited.
Checklist
make allwas not run locallymake docs) - no docs changes needed