Repository navigation
feat(typescript-zod): validate additional properties - #3111
Open
louis-bompart wants to merge 3 commits into
Open
louis-bompart wants to merge 3 commits into
louis-bompart wants to merge 3 commits into
Conversation
louis-bompart
marked this pull request as ready for review
August 4, 2026 20:57
…zod-additional-properties # Conflicts: # packages/quicktype-core/src/language/TypeScriptZod/TypeScriptZodRenderer.ts
Generated-output differences295 files differ — 295 modified, 0 new, 0 deleted |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve JSON Schema
additionalPropertiesbehavior in TypeScript Zod output using Zod 3/4-compatible object methods.Related Issue
N/A
Motivation and Context
TypeScript Zod previously discarded unknown-key semantics and converted objects with typed additional properties into broad maps. This change preserves fixed object properties and validates unknown keys according to the source schema.
Previous Behaviour / Output
New Behaviour / Output
Depending on
additionalProperties, generated schemas now use.strict(),.passthrough(), or.catchall(...).How Has This Been Tested?
npm run test:unit -- test/unit/typescript-zod-additional-properties.test.tsQUICKTEST=true FIXTURE=schema-typescript-zod npm run test:fixtures -- test/inputs/schema/class-with-additional.schemaThe unit test asserts all three generated Zod forms. The existing schema fixture accepts a typed additional boolean property and rejects an invalid string value.
Screenshots (if appropriate):
N/A