Skip to content

[avenger] Fix cache-memory integration test quoting - #73671

Merged
pelikhan merged 1 commit into
mainfrom
avenger/fix-cache-memory-test-3cc7cc0eef9d4f98
Nov 1, 2026
Merged

pelikhan merged 1 commit into
mainfrom
avenger/fix-cache-memory-test-3cc7cc0eef9d4f98

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updated the cache-memory integration test to match the compiler's double-quoted YAML rendering.
  • This fixes CI job Integration: Workflow Infra, where TestCacheMemoryMultipleIntegration/single_cache-memory (backward compatible) failed on the stale single-quote assertion.

Validation

  • go test -tags integration ./pkg/workflow -run ^TestCacheMemoryMultipleIntegration$ -count=1
  • make test-unit
  • make fmt
  • make lint was not run because the CI failure was a test assertion, not a lint failure.

Generated by 🦸 Avenger · copilot · routed: gpt56 max · ~8 AIC · ⌖ ~1 AIC · ⊞ 3.9K · ◷

  • expires on Nov 2, 2026, 5:41 PM UTC-08:00
@pelikhan
pelikhan marked this pull request as ready for review November 1, 2026 02:34
Copilot AI auto review requested due to automatic review settings November 1, 2026 02:34
@pelikhan
pelikhan merged commit 6cf066f into main Nov 1, 2026
10 checks passed
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~7 AIC · ⌖ ~7 AIC · ⊞ 15.1K · ◷

Generated by Ponytail Reviewer for #73671

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · ~15 AIC · ⌖ ~16 AIC · ◇ ~8 AIC · ⊞ 12.7K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: opus55 medium · ~12 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The stale integration-test expectation now matches the compiler’s current double-quoted YAML output, with backward-compatible single-cache coverage preserved and no active review issues.

No open issues 🎉

What changed in this PR

Updates the cache-memory integration test to match the compiler’s current double-quoted YAML rendering, preventing a false CI failure without changing production behavior.

Changes:

  • Replaced the stale single-quoted GH_AW_CACHE_DIR expectation with the double-quoted form.
  • Preserved existing coverage for the backward-compatible single-cache configuration.
File Description
pkg/​workflow/​cache_memory_integration_test.go Updates the expected cache directory YAML quoting in the integration test.

Review effort: Lite (auto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants