Repository navigation
[avenger] Fix cache-memory integration test quoting - #73671
Conversation
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The stale integration-test expectation now matches the compiler’s current double-quoted YAML output, with backward-compatible single-cache coverage preserved and no active review issues.
No open issues 🎉
What changed in this PR
Updates the cache-memory integration test to match the compiler’s current double-quoted YAML rendering, preventing a false CI failure without changing production behavior.
Changes:
- Replaced the stale single-quoted
GH_AW_CACHE_DIRexpectation with the double-quoted form. - Preserved existing coverage for the backward-compatible single-cache configuration.
| File | Description |
|---|---|
pkg/workflow/cache_memory_integration_test.go |
Updates the expected cache directory YAML quoting in the integration test. |
Review effort: Lite (auto)
Summary
Integration: Workflow Infra, whereTestCacheMemoryMultipleIntegration/single_cache-memory (backward compatible)failed on the stale single-quote assertion.Validation
go test -tags integration ./pkg/workflow -run ^TestCacheMemoryMultipleIntegration$ -count=1make test-unitmake fmtmake lintwas not run because the CI failure was a test assertion, not a lint failure.