Repository navigation
Route Documentation Unbloat instead of pinning claude-sonnet-5.5 - #73388
Conversation
…ude-sonnet-5.5 Co-authored-by: SivaKesava1 <11771739+SivaKesava1@users.noreply.github.com>
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Review: comment
One medium-risk concern was identified: cost/economy routing is unconstrained, so the scheduled PR-producing workflow can change behavior as the provider model pool changes. See the inline comment.
💡 Review scope
Reviewed the changed workflow frontmatter and the supplied PR metadata. The generated lock file was not included in the pre-fetched patch, so its runtime details were not independently assessed. No additional blocking correctness issue was established from the available changed lines.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.7K
Comment /review to run again
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the cost-focused model-routing change.
No open issues 🎉
What changed in this PR
Moves Documentation Unbloat to gh-aw’s cost-focused model routing, following the rollout in #73381. The change aims to reduce run costs without changing the documentation task or its safeguards.
Changes:
- Replaces the Sonnet pin with
goal: costandmode: economy, retaining Pi and the 90-turn limit. - Adds router setup and passes the selected model, effort, and routing status downstream.
- Switches threat detection and evals to their default model aliases.
| File | Description |
|---|---|
.github/workflows/unbloat-docs.md |
Enables cost/economy routing; leaves the prompt, tools, and safe outputs unchanged. |
.github/workflows/unbloat-docs.lock.yml |
Compiles routing setup, pinned router image, runtime metadata, and downstream model defaults. |
Review effort: Balanced (auto)
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design (pr-triage recommended this + /improve-codebase-architecture). The change mechanically follows the established model-routing pattern used across the repo (copilot-session-insights.md, safe-output-health.md, claude-code-user-docs-review.md all use goal: cost / mode: economy) — one worthwhile mode question flagged inline.
📋 Key Themes & Highlights
Key Theme
- Mode choice vs. workflow risk profile:
unbloat-docs.mdcreates PRs withauto-merge: true— the project's ownmodel-routing.mddocs recommendmode: robustfor exactly this class of workflow ("tasks where a failed run is costly, such as workflows that open pull requests"), whileeconomyis documented for "triage, labeling, and summaries." Sibling routed workflows that auto-merge or act with less oversight (avenger.md) usemode: balanced, noteconomy. Worth a deliberate justification in the PR description ifeconomyis intentional, given the auto-merge safety net is thinner than human-reviewed PR flows.
Positive Highlights
- ✅ Change is minimal and consistent with the repo's existing model-routing migration pattern (follows the same
engine.model-routingshape used in ~10 other workflows). - ✅ PR description is unusually thorough: cites the AIC math driving the change, lists exactly what
gh aw compilealtered in the lock file, and calls out validation gaps (CodeQL timeout, pre-existingTestNoRawOctalPermissionLiteralsInOSCallsfailure) honestly instead of hiding them. - ✅ Correctly scoped —
max-turns, prompt, triggers, tools, and safe-outputs are untouched; only the model selection strategy changes. - ✅ Lock file regeneration via
gh aw compilewas confirmed to not affect other workflows.
Note on investigation scope: This review relied on the pre-fetched 18-line diff (small, not truncated) plus targeted doc/sibling-workflow reads; no cross-cutting architectural exploration was needed given the PR's narrow footprint.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · ~63 AIC · ⌖ ~16 AIC · ⊞ 10.8K
Comment /matt to run again
Documentation Unbloat pins
copilot/claude-sonnet-5.5, so threat detection and evals also run on Sonnet. Those two jobs account for about 71% of its roughly 28 AIC per run. This PR replaces the pin with model routing (goal: cost,mode: economy), following the earlier routed workflows.Workflow frontmatter (
unbloat-docs.md)model: copilot/claude-sonnet-5.5.max-turns, the prompt, triggers, tools, sub-agents and safe outputs are unchanged.allowed-modelsor blocked models.Compiled lock (
unbloat-docs.lock.yml)ghcr.io/github/gh-aw-firewall/router:0.29.0@sha256:….GH_AW_PI_MODELandGH_AW_PI_NATIVE_PROVIDERfrom the agent step.model,model_effort,model_routing_status) to the downstream jobs.detectionandevalsdefault models instead of the pin.make recompilechanged no other workflows.Validation
make agent-finishstopped attest-integration, so its later steps didn't run. The only failure isTestNoRawOctalPermissionLiteralsInOSCalls, which flagspkg/cli/logs_harbor_trial.go. This PR doesn't touch that file, so it should also fail onmain; that hasn't been checked. The CodeQL scan timed out and didn't complete.Follow-up (not in this PR)
The issue's post-merge checks:
gpt-5.6-lunaatmaxeffort.mode: balanced.