Repository navigation
Make setup action reference tests deterministic - #72155
Conversation
Seed the successful SHA resolution path and use an explicit failing resolver for fallback coverage. Check the release-mode workflow against a cached SHA pin instead of assuming v1.0.0 cannot resolve. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Test Quality Sentinel completed test quality analysis. Caution agentic threat detected DetailsPotential security threats were detected in the agent output. Review the workflow run logs for details. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes preserve success, fallback, and checkout coverage with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Makes setup action reference tests deterministic by removing assumptions about whether v1.0.0 resolves on GitHub. Production behavior is unchanged.
Changes:
- Seed resolver caches with a fixed SHA to verify successful SHA pinning.
- Use the failing resolver stub for explicit tag-fallback coverage while preserving release-mode checks that local action checkouts are omitted.
| File | Description |
|---|---|
pkg/workflow/local_action_permissions_test.go |
Assert a cached SHA-pinned remote setup reference in release mode. |
pkg/workflow/action_reference_test.go |
Separate deterministic SHA-resolution success and tag-fallback cases. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Summary
CI and CGO tests started failing once
v1.0.0became a real, resolvable tag. The tests assumed resolution would fail or that release-mode setup references would remain tag-based.Production behavior is unchanged. The separate latest-release alignment failure remains:
github/gh-awreportsv0.93.5, whilegithub/gh-aw-actionsreportsv1.0.0. This PR does not weaken that guard or modify release state.Validation
make buildmake fmtgo test ./pkg/workflow -run '^TestResolveSetupActionReference' -count=1go test -tags=integration ./pkg/workflow -run '^TestLocalActionPermissions' -count=1make agent-report-progress(impacted Go tests, change-scoped lint, and workflow lock-file drift checks)