Repository navigation
Separate workflow title parsing from file-I/O benchmark costs - #71927
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix performance regression in ExtractWorkflowNameFromFile
Oct 25, 2026
pelikhan
marked this pull request as ready for review
October 25, 2026 17:30
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The daily results collector rejects decimal timings, so the new benchmark is excluded from historical tracking and regression analysis.
1 open issue
What changed in this PR
This PR separates workflow-title parsing costs from file I/O in gh-aw’s performance diagnostics. Production behavior is unchanged, and the reported slowdown remains unresolved.
Changes:
- Adds a parser-only benchmark to the performance target.
- Validates file-benchmark results and adds parser regression tests.
| File | Description |
|---|---|
pkg/cli/commands_utils_test.go |
Adds parser tests, an isolated benchmark, and file-benchmark validation. |
Makefile |
Includes the parser-only benchmark in bench-performance. |
Review effort: Max
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractWorkflowNameFromFilewas reported 130.6% slower: 5,318 ns/op versus a historical median of 2,306 ns/op. Local profiling points to syscall overhead, with parsing alone taking ~68 ns versus ~5.3 µs for file extraction.BenchmarkFastParseTitleFromReaderto daily performance monitoring, separating parsing cost from file I/O.Scope: Diagnostic coverage only; production behavior is unchanged, and the reported runtime slowdown remains unresolved.