Repository navigation
Fix compiler integration fixtures for action pin linting - #71692
Conversation
Opt synthetic action-tag tests into mutable refs while verifying default rejection. Pin the custom safe-update fixture and verify its manifest baseline and unchanged recompilation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The test-only changes preserve production validation, with no blocking issues identified.
1 open issue
What changed in this PR
Updates gh-aw compiler integration fixtures to satisfy action-pin linting while preserving production validation.
Changes:
- Opt synthetic action-tag tests into
--allow-action-refsand verify rejection without a lock file when omitted. - SHA-pin the safe-update fixture and verify its manifest baseline and unchanged recompilation behavior.
| File | Description |
|---|---|
pkg/cli/compile_safe_update_integration_test.go |
Pins the custom action and checks baseline persistence across recompilation. |
pkg/cli/compile_integration_test.go |
Adds explicit action-reference opt-ins and rejection coverage. |
Review effort: Max
| lockFilePath := filepath.Join(setup.workflowsDir, "test-actions-repo.lock.yml") | ||
| if tt.wantError { | ||
| if err == nil { | ||
| t.Fatal("Compile should reject a mutable action tag without --allow-action-refs") |
|
🎉 This pull request is included in a new release. Release: |
Default compile linting now correctly rejects mutable action references, causing compiler action-reference and safe-update integration tests to fail on synthetic
@v9.9.9and@v1fixtures.--allow-action-refs, and verify that omitting the opt-in rejects compilation without emitting a lock file.Production validation is unchanged. The admission-output
needs-consistencywarnings were advisory, not the cause of these failures.Validation
TestSafeUpdate.*integration tests passed.make fmtandmake agent-report-progresspassed, including Go lint, impacted tests, and all 348 workflow drift checks.