Skip to content

fix: refresh verified TLA runtime checksum - #71679

Merged
pelikhan merged 2 commits into
mainfrom
pelikhan-super-enigma
Oct 24, 2026
Merged

pelikhan merged 2 commits into
mainfrom
pelikhan-super-enigma

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Why

Daily Workflow Security Model run 40065872119 stopped during runtime preparation because upstream replaced tla2tools.jar behind the v1.8.0 URL. The previous checksum passed on October 22; missing safe-output artifacts and the conclusion failure are downstream symptoms.

Changes

Refresh the fixed SHA-256 in both runtime gates and regenerate the workflow lock. Extend regression coverage to check the generated lock alongside the source, checker, and documentation. Preserve strict verification and historical model evidence.

The new digest, d15655eeaff4b3f7b3d65c46b838bc0f35d131b2ef4b1e473689b62c98d4726f, was independently calculated from the official download and matched to asset 670958559 and its upload in upstream build 40049599214, at commit 2ef2af8c767b76e5db5cba2878f027ac07aad36c.

This repairs the current pin, not the mutable upstream distribution. Document the provenance, its attestation limits, and the coordinated update procedure. Future replacements must still fail closed; never derive the expected digest dynamically.

Validation

Passed:

  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s specs/workflow-security -p '*_test.py' (27 fixture-only tests).
  • make build.
  • ./gh-aw compile daily-workflow-security-model --validate --shellcheck --no-check-update --schedule-seed github/gh-aw --action-mode dev --json.
  • make check-stale-lock-files and git diff --check.
  • Read-only security review of source and generated lock: PASS, no confirmed vulnerabilities.

Limitations:

  • make recompile and make agent-report-progress were attempted but did not finish repository-wide validation under GitHub API/DNS failures. Generated side effects were restored; only the intended five files changed.
  • Dry-run compilation emitted no diagnostic lock: existing host scripts are prohibited in dry-run mode, and the model-inventory lookup failed DNS resolution.
  • Installed actionlint reports the same six baseline findings for concurrency.queue and job.workflow_ref; this change adds none.
  • No downloaded JAR was executed and no workflow was dispatched. Existing experimental-feature and checkout-credential notices remain unchanged.
Align workflow and runner gates with upstream build 40049599214. Cover generated-lock pin consistency and document the mutable release URL and fail-closed update procedure.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 24, 2026 17:10
Copilot AI max review requested due to automatic review settings October 24, 2026 17:10
Regenerate the workflow security model lock from merged sources, preserving the verified TLA runtime checksum and the base CLI/scanner version updates.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Accepting the rebuilt upstream executable without independent build attestation warrants maintainer confirmation of the trust decision.

No open issues 🎉

What changed in this PR

Repairs runtime preparation for the daily workflow security model by refreshing the pinned TLA+ JAR checksum while preserving strict, fail-closed verification.

Changes:

  • Updates the checksum in both runtime gates and the generated workflow lock.
  • Extends regression coverage to check the generated lock’s checksum.
  • Documents asset provenance, attestation limits, and coordinated update requirements while preserving historical evidence.
File Description
specs/​workflow-security/​README.md Documents the refreshed digest, provenance, and update procedure.
specs/​workflow-security/​check.py Updates the checker’s required JAR checksum.
specs/​workflow-security/​check_test.py Refreshes the expected digest and adds generated-lock coverage.
.github/​workflows/​daily-workflow-security-model.md Updates the runtime preparation checksum.
.github/​workflows/​daily-workflow-security-model.lock.yml Carries the refreshed checksum and regenerated workflow hashes.

Review effort: Max

@pelikhan
pelikhan merged commit 4a867a1 into main Oct 24, 2026
4 checks passed
@pelikhan
pelikhan deleted the pelikhan-super-enigma branch October 24, 2026 17:22
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.93.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants