Repository navigation
fix: refresh verified TLA runtime checksum - #71679
Merged
Merged
Conversation
Align workflow and runner gates with upstream build 40049599214. Cover generated-lock pin consistency and document the mutable release URL and fail-closed update procedure. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Regenerate the workflow security model lock from merged sources, preserving the verified TLA runtime checksum and the base CLI/scanner version updates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Accepting the rebuilt upstream executable without independent build attestation warrants maintainer confirmation of the trust decision.
No open issues 🎉
What changed in this PR
Repairs runtime preparation for the daily workflow security model by refreshing the pinned TLA+ JAR checksum while preserving strict, fail-closed verification.
Changes:
- Updates the checksum in both runtime gates and the generated workflow lock.
- Extends regression coverage to check the generated lock’s checksum.
- Documents asset provenance, attestation limits, and coordinated update requirements while preserving historical evidence.
| File | Description |
|---|---|
specs/workflow-security/README.md |
Documents the refreshed digest, provenance, and update procedure. |
specs/workflow-security/check.py |
Updates the checker’s required JAR checksum. |
specs/workflow-security/check_test.py |
Refreshes the expected digest and adds generated-lock coverage. |
.github/workflows/daily-workflow-security-model.md |
Updates the runtime preparation checksum. |
.github/workflows/daily-workflow-security-model.lock.yml |
Carries the refreshed checksum and regenerated workflow hashes. |
Review effort: Max
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Daily Workflow Security Model run 40065872119 stopped during runtime preparation because upstream replaced
tla2tools.jarbehind thev1.8.0URL. The previous checksum passed on October 22; missing safe-output artifacts and the conclusion failure are downstream symptoms.Changes
Refresh the fixed SHA-256 in both runtime gates and regenerate the workflow lock. Extend regression coverage to check the generated lock alongside the source, checker, and documentation. Preserve strict verification and historical model evidence.
The new digest,
d15655eeaff4b3f7b3d65c46b838bc0f35d131b2ef4b1e473689b62c98d4726f, was independently calculated from the official download and matched to asset670958559and its upload in upstream build 40049599214, at commit2ef2af8c767b76e5db5cba2878f027ac07aad36c.This repairs the current pin, not the mutable upstream distribution. Document the provenance, its attestation limits, and the coordinated update procedure. Future replacements must still fail closed; never derive the expected digest dynamically.
Validation
Passed:
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s specs/workflow-security -p '*_test.py'(27 fixture-only tests).make build../gh-aw compile daily-workflow-security-model --validate --shellcheck --no-check-update --schedule-seed github/gh-aw --action-mode dev --json.make check-stale-lock-filesandgit diff --check.Limitations:
make recompileandmake agent-report-progresswere attempted but did not finish repository-wide validation under GitHub API/DNS failures. Generated side effects were restored; only the intended five files changed.concurrency.queueandjob.workflow_ref; this change adds none.