Repository navigation
Fix Pi evals reading stale workflow prompts - #71664
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
A reproduced answer-parsing error can record results that contradict the Pi judge's response.
1 open issue
What changed in this PR
Fixes gh-aw’s Pi evaluation prompt handoff so the judge receives the BinEval questions instead of restored workflow instructions.
Changes:
- Write the BinEval prompt to both prompt files and clear the stale system prompt.
- Add regression coverage for restored Pi prompts and clean up prompt files after tests.
| File | Description |
|---|---|
| actions/setup/js/run_evals.test.cjs | Tests replacement of restored Pi prompts and adds cleanup. |
| actions/setup/js/run_evals.cjs | Prepares combined and split prompts for evaluation. |
Review effort: Max
|
@copilot address the following outstanding work in one pass:
Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI. Sous-chef head: 8e3cce5
|
…-evals-job Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
| } | ||
|
|
||
| const prompt = buildEvalPrompt(questions, agentOutputContent); | ||
| const prompt = buildEvalPrompt(questions, sanitizeAgentOutputForPrompt(agentOutputContent)); |
There was a problem hiding this comment.
Added an explicit guard that treats the serialized agent output as untrusted evidence and tells the evaluator to ignore instructions inside it, while retaining the existing JSON escaping. The regression test covers both. Commit: 5332633.
|
@copilot address the following outstanding work in one pass:
Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI. Sous-chef head: 38daf54
|
|
@copilot resolve the merge conflicts on this branch. |
…-evals-job # Conflicts: # actions/setup/js/model_pin_check.test.cjs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Resolved the conflict in |
|
@copilot address the following outstanding work in one pass:
Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI. Sous-chef head: 5332633
|
|
🎉 This pull request is included in a new release. Release: |

Pi evals read the main workflow’s restored
user.txtandsystem.txtinstead of the BinEval prompt, producingUNKNOWNanswers while reporting success.prompt.txtanduser.txt; clearsystem.txtto remove stale workflow instructions.