Repository navigation
[log] Add debug logging to webhook, model-routing, and JS taint-summary files - #71327
Merged
pelikhan merged 1 commit intoOct 23, 2026
Merged
Conversation
These three files were the only genuine zero-logging candidates in the scanned pool; every other candidate already used a shared package-level logger with extensive call sites. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pelikhan
deleted the
log-enhancement-webhook-model-routing-taint-27f11bdd061a6e6e
branch
October 23, 2026 03:42
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug logging added to 3 files
Added meaningful
pkg/loggerdebug logging to the only genuine zero-logging candidates found in the scanned manifest pool.Files changed:
pkg/workflow/webhook.go— newwebhookLog(workflow:webhook): logs webhook catalog load counts, subscription-parsing entry/exit, and the early skip when nogateway-dispatchtriggers are configured.pkg/workflow/model_routing_candidates.go— newmodelRoutingCandidatesLog(workflow:model_routing_candidates): logs allowed-models resolution counts, policy-excluded candidate groups, and the final resolved AWF candidate count.pkg/workflow/taint/javascript_summaries.go— newjavascriptSummariesLog(workflow:taint:javascript_summaries): logs catalog/hash verification failures and unknown summary transfer-function models.Why only 3 files instead of 5
The pre-flight manifest files_needing_logger and missing_logger_import lists are mostly false positives for this codebase: many files share a package-level logger declared in a sibling file (e.g. workflowLog in compiler.go, threatLog, auditLog, addInteractiveLog, actionPinsLog), so a per-file missing-logger-import check flags files that already log extensively through the shared logger. I verified log-call counts across every first-round candidate (actionpins package, several pkg/cli files, several pkg/workflow files, pkg/agentdrain) before picking files, to avoid duplicating logging or padding the PR with already well-instrumented code. Only webhook.go, model_routing_candidates.go, and javascript_summaries.go had zero existing log calls.
Validation: make build and make fmt passed.
Steering: checked issue #71325 comments — none present, nothing to incorporate.
🤖 Generated with [Claude Code]((claude.com/redacted)