Repository navigation
Fix CI parser embedding and stale policy fixtures - #69943
Conversation
Include the native creation delivery module in embedded session parser sources, align CLI tester policy assertions with bounded coverage reporting, and exercise cached-audit ledger hydration across schema versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnosing-bugs and /tdd — this is a tightly scoped fix (one go:embed line + aligning fixtures/assertions to current contracts) with no actionable issues found.
📋 Review Notes
What was checked
actions/setup/session_parsers.go: adds the missing(go/redacted):embed js/work_queue_native_creation_delivery.cjsdirective, matching the stated root cause (embedded work queue delivery module referencing an unembedded file).pkg/cli/logs_cached_json_test.go:TestHydrateProcessedRunWithCachedAuditLedgernow table-tests current/unversioned/older/future schema versions, correctly exercising the realauditSchemaVersiongate inaudit_cache.go(hydrateProcessedRunWithCachedAuditreturns the processed run unchanged, with nilLedger, whenSchemaVersion != auditSchemaVersion). This is a genuine improvement in regression coverage per/tdd— good boundary coverage (older and future schema both verified, not just one direction).pkg/workflow/agentic_workflow_test.goanddaily_cli_tools_tester_policy_test.go: assertions updated to match current prompt text for expected-exclusion / incomplete-coverage reporting language, including a newassert.NotContainsguarding against the stale phrase reappearing — good regression-proofing per/diagnosing-bugs.
Positive Highlights
- ✅ Root cause addressed directly (missing embed), not just a symptom patch.
- ✅ New schema-version test cases are genuinely useful regression coverage, not just fixture churn.
- ✅
t.Parallel()added alongside the table-test refactor, improving test suite throughput.
No blocking issues identified; nothing requires inline comments.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 14.6 AIC · ⌖ 14.7 AIC · ⊞ 10.1K
Comment /matt to run again
There was a problem hiding this comment.
Verdict
No actionable blocking issues found in the changed lines.
Scope and limits
Static review only from the capped pre-fetched diff and metadata; I did not execute builds or tests. The changes look like a targeted embed fix plus test-fixture/policy assertion updates that match the current contract.🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 29.5 AIC · ⌖ 5.84 AIC · ⊞ 12.7K
Comment /review to run again
There was a problem hiding this comment.
🟢 Approval recommended
The focused embedding and test updates match existing contracts, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Fixes gh-aw CI failures by embedding a required delivery module and updating stale policy and audit test fixtures.
Changes:
- Embed the native work queue creation-delivery module.
- Align policy assertions with expected-exclusion and incomplete-coverage reporting.
- Test ledger hydration with current, unversioned, older, and future audit schemas.
| File | Description |
|---|---|
pkg/workflow/daily_cli_tools_tester_policy_test.go |
Update expected-exclusion policy assertions. |
pkg/workflow/agentic_workflow_test.go |
Match the current incomplete-status policy. |
pkg/cli/logs_cached_json_test.go |
Correct the audit fixture and test schema rejection. |
actions/setup/session_parsers.go |
Embed the required native delivery module. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Summary
Fix the failures observed in the latest main-branch CI and CGO runs:
work_queue_native_creation_delivery.cjs, which is required by the embedded work queue delivery module.No workflow source, generated lock, or cache compatibility behavior is weakened.
Validation
make build,make fmt, andmake agent-report-progresspass, including impacted Go tests, change-scoped linting, schema freshness, and recompilation of all 344 workflow locks without drift.Failure evidence: CI run and CGO run. No workflow runs were manually triggered.