Go bundler: resolve tarballs from npm registry metadata - #2453
Open
qmuntal wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the stated behavior and includes appropriate unit coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Updates the Go CLI bundler to resolve npm tarballs through registry metadata rather than constructed URLs.
Changes:
- Adds validated
dist.tarballmetadata resolution. - Downloads the shared CLI license once after platform bundles finish.
- Adds metadata resolution and validation tests.
| File | Description |
|---|---|
go/cmd/bundler/main.go |
Resolves tarball URLs and deduplicates license downloads. |
go/cmd/bundler/main_test.go |
Tests metadata URL resolution and missing tarballs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist.tarballURL instead of assuming npm's tarball path layout.Rationale
The bundler already determines the CLI version pinned by the selected SDK revision. This change keeps that version-selection behavior while making npm responsible for locating the corresponding platform and license archives. That removes coupling to npm's current archive URL naming convention.
Validation
go test ./cmd/bundler -count=1go test ./internal/embeddedcli -count=1