Skip to content

fix(fcm): Correctly map the string representation of the Android Config normal priority. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

fix(fcm): Correctly map the string representation of the Android Config normal priority. #452

merged 3 commits into from
Apr 11, 2025

Conversation

zSlicker
Copy link
Contributor

@zSlicker zSlicker commented Feb 4, 2025

No description provided.

@jonathanedey jonathanedey self-requested a review March 18, 2025 18:43
jonathanedey
jonathanedey approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @zSlicker for your contribution!
@jonathanedey
Copy link
Contributor

jonathanedey commented Mar 19, 2025 •
edited
Loading

Hi @zSlicker , could you push an empty commit here to re trigger our github action tests?
git commit --allow-empty -m "Empty commit message"
@jonathanedey
Copy link
Contributor

Hi @zSlicker, pinging here again since I didn't see the empty commit here. Could you push that empty commit to this PR?
@zSlicker
Copy link
Contributor Author

@jonathanedey done
@jonathanedey jonathanedey changed the title Android Config does not set a normal priority. Apr 11, 2025
@jonathanedey jonathanedey merged commit c41aff2 into firebase:master Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note
3 participants
@zSlicker @jonathanedey @lahirumaramba