Skip to content

Correct name of basic_date_time_no_millis #39367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Correct name of basic_date_time_no_millis #39367

merged 1 commit into from
Feb 27, 2019
+1 −1

Conversation

danielmitterdorfer
Copy link
Member

With this commit we correct the name of the Java time based formatter
for basic_date_time_no_millis. This fixes a copy&paste error where we
have assigned the name basic_t_time_no_millis to two different
formatters.
@danielmitterdorfer
Correct name of basic_date_time_no_millis
1cbd286 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra
alpar-t
alpar-t approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@danielmitterdorfer danielmitterdorfer removed the request for review from rjernst February 27, 2019 14:05
@danielmitterdorfer danielmitterdorfer merged commit 0d727a8 into elastic:master Feb 27, 2019
@danielmitterdorfer danielmitterdorfer deleted the fix-date-formatter-name branch February 27, 2019 14:05
@danielmitterdorfer
Copy link
Member Author

Thanks for the review @atorok!
danielmitterdorfer added a commit to danielmitterdorfer/elasticsearch that referenced this pull request Feb 27, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (elastic#39367)
91002e5 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
danielmitterdorfer added a commit to danielmitterdorfer/elasticsearch that referenced this pull request Feb 27, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (elastic#39367)
7008e90 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
@danielmitterdorfer
Copy link
Member Author

Backports:
danielmitterdorfer added a commit that referenced this pull request Feb 27, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (#39367) (#39454)
2ccba18 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
danielmitterdorfer added a commit that referenced this pull request Feb 27, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (#39367) (#39455)
275a65d 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
danielmitterdorfer added a commit to danielmitterdorfer/elasticsearch that referenced this pull request Feb 27, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (elastic#39367)
9e6c4ca 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`.
danielmitterdorfer added a commit that referenced this pull request Feb 28, 2019
@danielmitterdorfer
Correct name of basic_date_time_no_millis (#39367) (#39457)
d0ba29c 
With this commit we correct the name of the Java time based formatter
for `basic_date_time_no_millis`. This fixes a copy&paste error where we
have assigned the name `basic_t_time_no_millis` to two different
formatters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label v6.7.0 v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
5 participants
@danielmitterdorfer @elasticmachine @alpar-t @jakelandis @michaelbaamonde