Skip to content

[ML] Resolve 7.0.0 TODOs in ML code #36842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2018
Merged

[ML] Resolve 7.0.0 TODOs in ML code #36842

merged 4 commits into from
Dec 20, 2018

Conversation

droberts195
Copy link
Contributor

This change cleans up a number of ugly BWC
workarounds in the ML code.

7.0 cannot run in a mixed version cluster with
versions prior to 6.7, so code that deals with
these old versions is no longer required.

Closes #29963
@droberts195
[ML] Resolve 7.0.0 TODOs in ML code
9f1dbd6 
This change cleans up a number of ugly BWC
workarounds in the ML code.

7.0 cannot run in a mixed version cluster with
versions prior to 6.7, so code that deals with
these old versions is no longer required.

Closes elastic#29963
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core
dimitris-athanasiou
dimitris-athanasiou approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good getting rid of all that, doesn't it? :-)

Left a single comment for an unused variable but LGTM apart from that.
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java Outdated

public static boolean isMlNode(DiscoveryNode node) {
Map<String, String> nodeAttributes = node.getAttributes();
boolean enabled;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled is not used
@droberts195
Copy link
Contributor Author

run gradle build tests 2
@droberts195 droberts195 merged commit 0f2f00a into elastic:master Dec 20, 2018
@droberts195 droberts195 deleted the action_v7_todos branch December 20, 2018 12:50
@droberts195 droberts195 mentioned this pull request Dec 20, 2018
Merged
1 task
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :ml Machine learning v7.0.0-beta1
4 participants
@droberts195 @elasticmachine @dimitris-athanasiou @jimczi