Remove deprecated Graph endpoints #35956
Conversation
We had some endpoints in Graph that are deprecated for removal in 7.0.0. This commit removes these deprecated endpoints.
jasontedor
added
>breaking
:Search/Search
|
Pinging @elastic/es-search |
| */ | ||
| public class RestGraphAction extends XPackRestHandler { | ||
| private static final Logger logger = LogManager.getLogger(RestGraphAction.class); | ||
| private static final DeprecationLogger deprecationLogger = new DeprecationLogger(logger); |
There was a problem hiding this comment.
It will have to temporarily come back in another pull request. 😞
| controller.registerHandler(GET, "/{index}" + URI_BASE + "/graph/_explore", this); | ||
| controller.registerHandler(POST, "/{index}" + URI_BASE + "/graph/_explore", this); | ||
| controller.registerHandler(GET, "/{index}/{type}" + URI_BASE + "/graph/_explore", this); | ||
| controller.registerHandler(POST, "/{index}/{type}" + URI_BASE + "/graph/_explore", this); |
There was a problem hiding this comment.
Technically speaking the doc type in urls is being deprecated in 7.0. The general pattern we're adopting is it's not flagged as deprecated if you also pass an include_type_name=false along with the request.
I can pick this up as part of types removal work if you want to leave that out for now.
There was a problem hiding this comment.
@markharwood Yeah, I would rather leave the typeless work separate from this change; thanks for offering to pick that up. My aim here is only to remove the already deprecated endpoints. I am going to turn around in a follow-up and add new endpoints (/_graph/explore) and deprecate all endpoints that have /{index}/_xpack.
|
LGTM |
We had some endpoints in Graph that are deprecated for removal in 7.0.0. This commit removes these deprecated endpoints.