Skip to content

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Nov 16, 2018

This PR adds deprecation warnings to the relevant Rest*Action classes, plus tests in Rest*ActionTests. No updates to REST tests, the Java HLRC, or documentation were necessary, since they didn't make use of types.

@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types >deprecation v7.0.0 labels Nov 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jtibshirani jtibshirani changed the title Deprecated types in search and multi search templates. Nov 16, 2018
@jtibshirani jtibshirani force-pushed the types-in-search-template branch from 618dd53 to 43da7a1 Compare November 17, 2018 02:12
@jtibshirani jtibshirani force-pushed the types-in-search-template branch from 43da7a1 to 501f2f7 Compare November 26, 2018 19:20
@jtibshirani jtibshirani force-pushed the types-in-search-template branch from 501f2f7 to a6994e4 Compare November 26, 2018 20:44
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a description to this pull request?

@jtibshirani jtibshirani merged commit 25c416b into elastic:master Nov 27, 2018
@jtibshirani jtibshirani deleted the types-in-search-template branch November 27, 2018 18:19
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 28, 2018
* master:
  DOCS Audit event attributes in new format (elastic#35510)
  Scripting: Actually add joda time back to whitelist (elastic#35965)
  [DOCS] fix HLRC ILM doc misreferenced tag
  Add realm information for Authenticate API (elastic#35648)
  [ILM] add HLRC docs to remove-policy-from-index (elastic#35759)
  [Rollup] Update serialization version after backport
  [Rollup] Add more diagnostic stats to job (elastic#35471)
  Build: Fix gradle build for Mac OS (elastic#35968)
  Adds deprecation logging to ScriptDocValues#getValues. (elastic#34279)
  [Monitoring] Make Exporters Async (elastic#35765)
  [ILM] reduce time restriction on IndexLifecycleExplainResponse (elastic#35954)
  Remove use of AbstractComponent in xpack (elastic#35394)
  Deprecate types in search and multi search templates. (elastic#35669)
  Remove fromXContent from IndexUpgradeInfoResponse (elastic#35934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
4 participants