Remove potential nio selector leak #27825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ESSelector is created an underlying nio selector is opened. This selector is closed by the event loop after close has been signalled by another thread. However, there is a possibility that an ESSelector is created and some exception in the startup process prevents it from ever being started (however, close will still be called). The allows the selector to leak. This commit addresses this issue by having the signalling thread close the selector if the event loop is not running when close is signalled.
Tim-Brooks
added
:Distributed Coordination/Network
jasontedor
approved these changes
Dec 14, 2017
| } catch (InterruptedException e) { | ||
| eventHandler.uncaughtException(e); | ||
| Thread.currentThread().interrupt(); | ||
| throw new IllegalStateException("CountDownLatch got interrupted", e); |
There was a problem hiding this comment.
Can we say something more precise like "selector was interrupted while closing"?
Tim-Brooks
added a commit
that referenced
this pull request
Dec 14, 2017
When an ESSelector is created an underlying nio selector is opened. This selector is closed by the event loop after close has been signalled by another thread. However, there is a possibility that an ESSelector is created and some exception in the startup process prevents it from ever being started (however, close will still be called). The allows the selector to leak. This commit addresses this issue by having the signalling thread close the selector if the event loop is not running when close is signalled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
ESSelectoris created an underlying nio selector is opened.This selector is closed by the event loop after
closehas beensignaled by another thread.
However, there is a possibility that an
ESSelectoris created andsome exception in the startup process prevents it from ever being
started (however, `close`` will still be called). The allows the
selector to leak.
This commit addresses this issue by having the signaling thread close
the selector if the event loop is not running when close is signaled.