Ensure that gcs client creation is privileged #25938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#25932. Currently when we create the `GoogleCloudStorageService` client we do not wrap that call in a doPrivileged block. The call might open a connection. This commit ensures that the creation is wrapped in a doPrivileged block.
|
@tbrooks8 I see that you merged it in master branch. I believe it should be merged as well in 6.0 and 6.x branches, right? |
jasontedor
pushed a commit
that referenced
this pull request
Jul 28, 2017
This is related to #25932. Currently when we create the `GoogleCloudStorageService` client we do not wrap that call in a doPrivileged block. The call might open a connection. This commit ensures that the creation is wrapped in a doPrivileged block.
jasontedor
pushed a commit
that referenced
this pull request
Jul 28, 2017
This is related to #25932. Currently when we create the `GoogleCloudStorageService` client we do not wrap that call in a doPrivileged block. The call might open a connection. This commit ensures that the creation is wrapped in a doPrivileged block.
|
@dadoonet I backported this to 6.0 and 6.x. |
|
Something is weird. This morning I just restarted my GCE instance and ran again a snapshot creation and it succeeded: {
"acknowledged" : true
}Nice right? But the problem is that I did not apply the patch on my instance. So I don't understand how it failed the first time. |
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #25932. Currently when we create the
GoogleCloudStorageServiceclient we do not wrap that call in adoPrivileged block. The call might open a connection. This commit
ensures that the creation is wrapped in a doPrivileged block.