fix: allow importing inside a NodeJS worker with no workerData - #58
Open
DerZade wants to merge 1 commit into
Open
fix: allow importing inside a NodeJS worker with no workerData#58DerZade wants to merge 1 commit into
DerZade wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #57
I added a
?? {}to thethreads.workerDatadestructuring to ensure we have a valid value to destructure.In addition to that I added a new attribute with a unique name (includes a UUID, so it's basically impossible to set this by accident) to the
workerData.This ensures we can reliably verify that we are running in a worker thread, which was created by
web-worker. All other threads will use themainThreadcode path (and not theworkerThreadcode path).Something similar was already suggested by eshaz in #40: