Repository navigation
Packed resources - #155
Open
mymedia2 wants to merge 1 commit into
Open
Packed resources#155mymedia2 wants to merge 1 commit into
mymedia2 wants to merge 1 commit into
Conversation
Dynamically load packed resources from a separate file. This reduces amount of main memory required for linking stage.
john-preston
force-pushed
the
master
branch
from
September 13, 2023 17:06
e909a3a to
491a7fd
Compare
ilya-fedin
reviewed
Sep 5, 2026
| set(rcc_file ${target_name}.rcc) | ||
| set(rcc_path "${CMAKE_BINARY_DIR}/${rcc_file}") | ||
| source_group(TREE ${CMAKE_BINARY_DIR} PREFIX Resources FILES ${rcc_path}) | ||
| set(cmd_run "$<IF:$<BOOL:${qrc_files}>,,true>") # do nothing if qrc_files are empty |
Contributor
There was a problem hiding this comment.
This code is cross-platform and Windows will fail on it.
ilya-fedin
reviewed
Sep 5, 2026
| ) | ||
| endif() | ||
|
|
||
| if (DESKTOP_APP_USE_PACKED_RESOURCES) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (DESKTOP_APP_USE_PACKED_RESOURCES) | |
| if (DESKTOP_APP_PACKED_RESOURCES) |
| if (DESKTOP_APP_USE_PACKED_RESOURCES) | ||
| target_compile_definitions(common_options | ||
| INTERFACE | ||
| DESKTOP_APP_USE_PACKED_RESOURCES |
Contributor
There was a problem hiding this comment.
Suggested change
| DESKTOP_APP_USE_PACKED_RESOURCES | |
| DESKTOP_APP_PACKED_RESOURCES |
| set(rcc_file ${target_name}.rcc) | ||
| endif() | ||
|
|
||
| if (NOT DESKTOP_APP_USE_PACKED_RESOURCES) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (NOT DESKTOP_APP_USE_PACKED_RESOURCES) | |
| if (NOT DESKTOP_APP_PACKED_RESOURCES) |
| cmake_dependent_option(DESKTOP_APP_USE_PACKAGED_LAZY "Bundle recommended Qt plugins for self-contained packages." OFF LINUX OFF) | ||
| option(DESKTOP_APP_USE_PACKAGED_FONTS "Use preinstalled fonts instead of bundled patched ones." OFF) | ||
| option(DESKTOP_APP_USE_PACKAGED_RLOTTIE "Find rlottie using CMake instead of bundled patched one." OFF) | ||
| option(DESKTOP_APP_USE_PACKED_RESOURCES "Whether to pack resources into a separate archive." ${APPLE}) |
Contributor
There was a problem hiding this comment.
Suggested change
| option(DESKTOP_APP_USE_PACKED_RESOURCES "Whether to pack resources into a separate archive." ${APPLE}) | |
| option(DESKTOP_APP_PACKED_RESOURCES "Whether to pack resources into a separate archive." ${APPLE}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically load packed resources from a separate file. This reduces amount of main memory required for linking stage.
Main PR: telegramdesktop/tdesktop#17339