[unsupervised AI] Preserve worker name restrictions across restarts - #9357
Draft
Excelius-Wang wants to merge 1 commit into
Draft
[unsupervised AI] Preserve worker name restrictions across restarts#9357Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 32m 53s ⏱️ +52s For more details on these failures, see this check. Results for commit 5f36046. ± Comparison against base commit dc182bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I have reviewed, understood, and approved the implementation and tests in this pull request.
Closes #8600
Worker restrictions submitted by name are currently normalized to the
worker's concrete address. When a nanny restarts that worker, its address
changes while existing tasks retain the stale address and become
unschedulable.
This change preserves recognized worker names in
TaskStateand resolvesthem through the scheduler's existing alias map when selecting workers.
The P2P shuffle scheduler plugin uses the same resolver where it requires
concrete worker addresses.
pixi run lintMypy hooks passed.
Tests:
pytest --runslow -q distributed/tests/test_client.py -k 'restriction or restart_workers'pytest --runslow -q distributed/tests/test_scheduler.py -k 'valid_worker or restriction or alias'pytest --runslow -q distributed/shuffle/tests/test_shuffle.py::test_crashed_other_worker_during_barrier