Repository navigation
Draw points beyond scale limits when clip is disabled - #12347
Open
abdull-ah-med wants to merge 1 commit into
Open
abdull-ah-med wants to merge 1 commit into
abdull-ah-med wants to merge 1 commit into
Conversation
Line and scatter controllers skip points outside the index scale's user-defined min/max. When the dataset's `clip` is `false` (or false on the matching side), those points are visible outside the chart area, so they should not be trimmed. Fixes chartjs#11899
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11899
When a dataset sets
clip: false, the line and scatter controllers still drop points that fall outside the index scale's user-definedmin/max(_getStartAndCountOfVisiblePoints). Those points would be drawn outside the chart area, so with clipping disabled they — and the line segments leading to them — just disappear, which is what the codepen in the issue shows.Changes
_getStartAndCountOfVisiblePointstakes the dataset'sclipoption and ignores the index scale'smin(ormax) bound when clipping is disabled on the corresponding side of the chart area.clip: falsedisables both bounds; the per-side form (e.g.clip: {left: false, top: 0, right: 0, bottom: 0}) only keeps points beyond the unclipped side, takingreverseand vertical index axes into account.LineControllerandScatterControllerpassthis.options.clip.Tests
controller.line.tests.js(clip: false, per-side clip, per-side clip with a reversed scale) andcontroller.scatter.tests.js(clip: false). They fail onmasterand pass with the change.pnpm lint(eslint, markdown lint, type tests) passes.above-below-vertical-linechart,drawTimeFillFalse/*, radialLinearticks-below-zero, timeticks-round, timeseriesdata-timestamps) fail identically on unchangedmasteron my machine, so they're environment-related.Note: the filler plugin still clips fill to the index scale bounds (#12283), so with
clip: falsethe line now extends beyondmin/maxwhile any area fill stays within them. I left that alone to keep this focused; happy to extend it if you'd like the fill to follow.This change was prepared with AI assistance; I reviewed the diff and test results.