Repository navigation
Conversation
…uest stalls Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45928 +/- ##
=======================================
Coverage 84.76% 84.77%
=======================================
Files 3072 3072
Lines 206140 206158 +18
Branches 48549 48554 +5
=======================================
+ Hits 174741 174764 +23
+ Misses 28100 28095 -5
Partials 3299 3299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ip error log on abort Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a dashboard URL carries a saved filter state key (
native_filters_key), the page fetches that state before it loads. If the request never completes (a stalled connection, a proxy that drops the response), the dashboard stays on its loading spinner forever, because nothing loads until the request finishes.This change makes the dashboard wait at most 5 seconds for the saved filter state. After that it gives up and loads the dashboard with no saved filters, exactly as it already does when the key is missing or the request fails with an error. A warning is logged to the console; users see no new error message.
Also:
How the key gets written to the URL is untouched.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Automated:
npm run test -- src/dashboard/containers/DashboardPage.test.tsx(new tests cover a stalled request, a successful request, and leaving the page mid-request).Manual: open a dashboard with
?native_filters_key=<valid key>and, in browser dev tools, block or throttle the/filter_state/request indefinitely. The dashboard should load without the saved filters after about 5 seconds instead of spinning forever. With the request unblocked, the saved filters apply as before.ADDITIONAL INFORMATION
Note: once merged, this is a good candidate to cherry-pick to the 6.0 and 6.1 release branches.
🤖 Generated with Claude Code