Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolve references to serializer outputs by expression ID before pruning their nested fields. When rebuilding field accesses, use the schema that the serializer actually emits. Preserve the spelling of output columns requested by the query.
Why are the changes needed?
A case-insensitive reference can cause an array index exception during optimization. A serializer can also retain its original struct layout even when a narrower one was requested. In that case a projection can read a sibling of the requested field. For example, the constant-key Dataset query in the regression test returns
map-afor a request formap-b.This correctness fix was identified in the review of SPARK-60766 and can be backported independently.
Does this PR introduce any user-facing change?
Yes. Affected typed Dataset projections return the requested fields and preserve their output column names.
How was this patch tested?
Added two constant-selector regressions to
DatasetOptimizationSuitecovering the array error, output naming and the incorrect Map value. All 11 tests passed against Spark master’s 5.0.0-SNAPSHOT CI build with the standalone patch. On the unmodified parent, the other nine passed and the two new tests reproduced the wrong Map value and the array index exception. Changed-file ScalaStyle andgit diff --checkpassed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)