Skip to content

Gradle build improvements - #5387

Open
tpreviero wants to merge 10 commits into
apache:masterfrom
tpreviero:tpreviero/ge-trial
Open

tpreviero wants to merge 10 commits into
apache:masterfrom
tpreviero:tpreviero/ge-trial

Conversation

@tpreviero

Copy link
Copy Markdown

This PR provide little improvements to the Gradle build.

Description

Here's a brief list of what changed:

  • Add com.google.protobuf:protoc dependency for configurations
  • Upgrade version of Gradle Enterprise plugin to version 3.12.4
  • Upgrade version of com.gorylenko.gradle-git-properties to version 2.4.1
  • Use mavenCentral instead of jcenter as repository
  • Use archiveFileName instead of deprecated archiveName property
  • Extract swagger download from copySwagger task Explicitly define inputs and outputs for copyGWActions task

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@dgrove-oss dgrove-oss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I am requesting GHA to run the tests

@codecov-commenter

codecov-commenter commented Mar 24, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #5387 (770fc71) into master (60ca660) will decrease coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 770fc71 differs from pull request most recent head 67447e9. Consider uploading reports for the commit 67447e9 to get more accurate results

@@            Coverage Diff             @@
##           master    #5387      +/-   ##
==========================================
- Coverage   76.91%   76.29%   -0.63%     
==========================================
  Files         240      233       -7     
  Lines       14588    14324     -264     
  Branches      629      625       -4     
==========================================
- Hits        11221    10928     -293     
- Misses       3367     3396      +29     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95

style95 commented May 31, 2023

Copy link
Copy Markdown
Member

It seems this error is happening.

org.apache.openwhisk.standalone.StandaloneApiGwTests > classMethod FAILED
    java.lang.IllegalArgumentException: requirement failed
        at scala.Predef$.require(Predef.scala:268)
        at org.apache.openwhisk.standalone.StandaloneApiGwTests.$anonfun$waitForOtherThings$1(StandaloneApiGwTests.scala:39)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants