Skip to content

Bump akka management api version. - #5130

Open
rabbah wants to merge 1 commit into
apache:masterfrom
rabbah:akka-discovery-kubernetes
Open

Bump akka management api version.#5130
rabbah wants to merge 1 commit into
apache:masterfrom
rabbah:akka-discovery-kubernetes

Conversation

@rabbah

@rabbah rabbah commented Jun 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.
rabbah
rabbah commented Jun 10, 2021
View reviewed changes
Comment thread common/scala/build.gradle Resolved
@rabbah rabbah mentioned this pull request Jun 10, 2021
Open
ddragosd
ddragosd approved these changes Jun 10, 2021
View reviewed changes

@ddragosd ddragosd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks @rabbah !
@rabbah

rabbah commented Jun 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

In case it's cleaner, I created a separate PR just for the Mesos removal. We'll see based on feedback from dev list. This PR might be reduced to just one or two lines if so.
@rabbah
rabbah force-pushed the akka-discovery-kubernetes branch from c3013f9 to 4832dc1 Compare June 11, 2021 00:28
@rabbah

rabbah commented Jun 11, 2021

Copy link
Copy Markdown
Member Author

The build is unhappy with the last commit. Will check into it. The mesos bit is ok.
@rabbah
rabbah force-pushed the akka-discovery-kubernetes branch from 4832dc1 to e9f1f47 Compare June 18, 2021 20:32
@rabbah
rabbah force-pushed the akka-discovery-kubernetes branch from e9f1f47 to 3c9d18e Compare July 6, 2021 22:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@rabbah @ddragosd @dgrove-oss