Skip to content

feat: add a GitHub Action to check spelling - #5089

Draft
jbampton wants to merge 1 commit into
apache:masterfrom
jbampton:add-misspell
Draft

feat: add a GitHub Action to check spelling#5089
jbampton wants to merge 1 commit into
apache:masterfrom
jbampton:add-misspell

Conversation

@jbampton

@jbampton jbampton commented Mar 14, 2021

Copy link
Copy Markdown
Member

Description

misspell is a Golang tool to check spelling and pass in -w for autocorrect

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.
@jbampton
feat: add a GitHub Action to check spelling
e89fe60 
- I already fixed the spelling with this tool
- Run only on pull request
- Using https://github.com/client9/misspell
@codecov-io

codecov-io commented Mar 14, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5089 (e89fe60) into master (659b762) will decrease coverage by 7.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5089      +/-   ##
==========================================
- Coverage   81.92%   74.59%   -7.33%     
==========================================
  Files         213      206       -7     
  Lines       10316    10051     -265     
  Branches      452      449       -3     
==========================================
- Hits         8451     7498     -953     
- Misses       1865     2553     +688
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.48%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659b762...e89fe60. Read the comment docs.
cclauss
cclauss reviewed Feb 4, 2024
View reviewed changes
Comment thread .github/workflows/spelling.yml
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v2

@cclauss cclauss Feb 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v2
uses: actions/checkout@v4

https://github.com/actions/checkout/releases
Or...
@jbampton
jbampton marked this pull request as draft October 18, 2024 01:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jbampton @codecov-io @cclauss