Repository navigation
[AMORO-4417][CI] Run core CI when amoro-format-lance changes - #4418
Open
MarkAlex1234 wants to merge 1 commit into
Open
MarkAlex1234 wants to merge 1 commit into
MarkAlex1234 wants to merge 1 commit into
Conversation
amoro-ams depends on amoro-format-lance (test scope, and compile scope in two profiles), and core-hadoop{2,3}-ci build and test the whole reactor, but neither workflow triggered on amoro-format-lance/**. No other workflow watches it, so lance-only PRs ran no CI.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
core-hadoop2-ci.ymlandcore-hadoop3-ci.ymlbuild and test the whole reactor, but theirpull_request.pathsdon't includeamoro-format-lance/**, and no other workflow does either.amoro-amsdepends onamoro-format-lance(test scope, plus compile scope in two profiles), so lance-only PRs currently run no CI. Details are in the linked issue.Close #4417.
Brief change log
.github/workflows/core-hadoop2-ci.yml: add"amoro-format-lance/**"topull_request.paths..github/workflows/core-hadoop3-ci.yml: same.How was this patch tested?
pathslists change.pushtriggers are unchanged (they have no path filter).npx github:Continuous-Actions/dynamic-monorepo audit, a tool I maintain): the lance findings for both workflows go away.Documentation