Repository navigation
fix(stats): hide models listed in a secret - #52834
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A. Adding a model to the hardcoded
EXCLUDED_MODELSlist publishes its name in this public repo.Type of change
What does this PR do?
Adds a
StatsHiddenModelsSST secret (a comma-separated list, empty by default) to the stats sync service. Models in it are handled likeEXCLUDED_MODELS, and rows already stored for them are deleted.StatsSyncServiceis linked to the secret. The stats app never reads it.How did you verify your code works?
bun test src/domain/inference.test.ts: 20 pass. The new test checks thathiddenModelsreaches the exclusion list of every usage, geo, and retention query.bun run typecheckinpackages/stats/corepasses.r2-sql.test.ts("database is locked") also fail on unmodifieddev.Screenshots / recordings
N/A, no UI change.
Checklist