This repository was archived by the owner on May 29, 2019. It is now read-only.
Tabs - Changing from ng-class + display:none to ng-if - #6479
Open
picheli20 wants to merge 1 commit into
Open
Conversation
mmarchini
reviewed
Apr 7, 2017
| @@ -3,8 +3,9 @@ | |||
| <div class="tab-content"> | |||
| <div class="tab-pane" | |||
There was a problem hiding this comment.
It should be class="tab-pane active", otherwise the content won't show
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are using same directive inside the tab (for exemple angular-ellipsis) which needs to do same DOM manipulation, the
ng-classwithdisplay:none;compiles the JS code without a HTML.Changing to
ng-ifwe make the "directives" be activated when the user enter in the tab, not in the page.