This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): Adding support for dropUp class - #6300
Open
bartkiewicz wants to merge 8 commits into
Open
Conversation
added 8 commits
October 25, 2016 14:46
fix(dropdown): fix for dropUp and adding autoplacement fix(dropdown): Adding support for dropUp class fix(dropdown): positioning fix for right-align, dropup, and auto
|
Any word on getting this merged in? |
This was referenced Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #6030.
Was not sure if the comment in the original issue was suggesting the dropUp check be done in the uibPosition, but it made more sense to me to check in dropdown, since why would anything else care about a dropUp class.