Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(datepicker): add monthColumns attribute - #5650

Open
steveneiden wants to merge 14 commits into
angular-ui:masterfrom
steveneiden:feature/add-monthColumns-attribute
Open

feat(datepicker): add monthColumns attribute#5650
steveneiden wants to merge 14 commits into
angular-ui:masterfrom
steveneiden:feature/add-monthColumns-attribute

Conversation

@steveneiden

@steveneiden steveneiden commented Mar 18, 2016

Copy link
Copy Markdown

Add ability to specify the number of columns on the month view of the datepicker
Eiden, Steven added 3 commits March 18, 2016 09:48
Eiden, Steven
feat(datepicker): add monthColumns attribute
e26ca6c 
Add ability to specify the number of columns on the month view of the datepicker
Eiden, Steven
fixed spacing and newLine issues
12b54be
Eiden, Steven
changed the order of datePicker options
20ec3d4
wesleycho
wesleycho reviewed Mar 18, 2016
View reviewed changes
Comment thread src/datepicker/datepicker.js Outdated
yearColumns: 5,
yearRows: 4
yearRows: 4,
monthColumns: 4

@wesleycho wesleycho Mar 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default number it seems to replace is 3 - this is probably what is breaking the unit tests.
@wesleycho

wesleycho commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

Linking related issue #5515
@wesleycho

wesleycho commented Mar 21, 2016

Copy link
Copy Markdown
Contributor

Can you squash your commits? Doing git rebase -i HEAD~[number of commits minus brackets] && git push -f should do the trick.

Also tests can be run locally via grunt or karma start. If using karma start, one can isolate what tests to run with fdescribe or fit.
@Mrman

Mrman commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

@wesleycho this PR can be closed too as part of #5515
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.