Skip to content

Autocomplete improvements #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Autocomplete improvements #2108

merged 2 commits into from
Jan 20, 2021

Conversation

thostetler
Copy link
Member

@thostetler thostetler commented Jan 19, 2021 •
edited
Loading

Updates search bar autocomplete

  • Simplify code, moves autocomplete to separate module
  • Remove highlighting, and reverts to more default behavior
    • Tabbing when menu item focused will now select it
    • Previews work for all menu items instead of only ones that have the same prefix
    • Previews won't happen on hover to keep from inadvertent selections while typing
  • Improves styling for better menu item contrast
  • Moves jQuery plugins to common module
@thostetler thostetler merged commit a97550b into adsabs:master Jan 20, 2021
@thostetler thostetler deleted the autocomplete-change branch January 20, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@thostetler