-
Notifications
You must be signed in to change notification settings - Fork 405
chore(java): spilt core and examples & support both Spring AI and ADK #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@holtskinner PTAL. Thanks |
@pstephengoogle Can you review? Should we turn these classes into the Java SDK? |
@AlbumenJ thank you so much for this contribution. I had a chance to review this and I think the idea might be very useful. We might want to target a java sdk similar to the python sdk. Primarily, the idea is to follow a similar design pattern, so we could support multiple transports as we progress. I am happy to collaborate with you further on this. |
samples/java/client-core/src/main/java/com/google/a2a/client/core/A2AClient.java
Outdated
Show resolved
Hide resolved
samples/java/client-core/src/main/java/com/google/a2a/client/core/A2AClient.java
Outdated
Show resolved
Hide resolved
samples/java/server-core/src/main/java/com/google/a2a/server/core/A2AServer.java
Outdated
Show resolved
Hide resolved
samples/java/server-core/src/main/java/com/google/a2a/server/core/A2AServer.java
Outdated
Show resolved
Hide resolved
samples/java/model/src/main/java/com/google/a2a/model/JSONRPCMessage.java
Outdated
Show resolved
Hide resolved
samples/java/server-core/src/main/java/com/google/a2a/server/core/A2AController.java
Outdated
Show resolved
Hide resolved
@rajeshvelicheti Thanks for your kindly review. I will update the code later. |
@rajeshvelicheti I have updated all the code according to your suggestion. Please review again. |
We now have a published java sdk https://github.com/a2aproject/a2a-java Can you convert these samples to use the new SDK? |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.Fixes #<issue_number_goes_here> 🦕