-
Notifications
You must be signed in to change notification settings - Fork 404
Add a2a on agent engine sample #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @wadave, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a new, extensive sample application that illustrates how to build and deploy a multi-agent system using the Agent2Agent (A2A) protocol on Google's Vertex AI Agent Engine. The sample features a central 'Host Agent' that orchestrates requests to specialized 'Cocktail' and 'Weather' agents. These specialized agents, in turn, interact with dedicated Model Context Protocol (MCP) servers to fulfill user queries, showcasing a robust architecture for complex AI agent interactions and highlighting the capabilities of A2A and Agent Engine. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive and well-structured sample for a multi-agent A2A setup on Agent Engine. The inclusion of two different implementation options for both the hosting agent and the frontend is a great way to showcase different approaches. My review focuses on improving dependency management, ensuring correct model usage, standardizing logging practices, and addressing minor inconsistencies in code and configuration files.
...t/a2a_multiagent_mcp_app/a2a_agents/cocktail_agent/deploy_cocktail_a2a_on_agent_engine.ipynb
Outdated
Show resolved
Hide resolved
...gine_multiagent/a2a_multiagent_mcp_app/a2a_agents/cocktail_agent/cocktail_agent_executor2.py
Show resolved
Hide resolved
...ngine_multiagent/a2a_multiagent_mcp_app/a2a_agents/cocktail_agent/cocktail_agent_executor.py
Outdated
Show resolved
Hide resolved
samples/python/agents/a2a_on_agent_engine_multiagent/.env.example
Outdated
Show resolved
Hide resolved
...gine_multiagent/a2a_multiagent_mcp_app/a2a_agents/cocktail_agent/cocktail_agent_executor2.py
Show resolved
Hide resolved
...gine_multiagent/a2a_multiagent_mcp_app/a2a_agents/hosting_agent_option1/remote_connection.py
Outdated
Show resolved
Hide resolved
...gine_multiagent/a2a_multiagent_mcp_app/a2a_agents/hosting_agent_option1/remote_connection.py
Outdated
Show resolved
Hide resolved
..._on_agent_engine_multiagent/a2a_multiagent_mcp_app/a2a_agents/weather_agent/weather_agent.py
Outdated
Show resolved
Hide resolved
...engine_multiagent/a2a_multiagent_mcp_app/a2a_agents/weather_agent/weather_agent_executor2.py
Show resolved
Hide resolved
...on_agent_engine_multiagent/a2a_multiagent_mcp_app/frontend_option2/register_to_agentspace.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Could you separate out the hosting agent/frontend options to just use one option for this example? It makes this project much larger than is probably needed, and could be harder for users to understand. Any way this can be simplified?
@holtskinner Thanks for the comments. I removed one of the options. |
@holtskinner please review it again. thanks. |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.Fixes #365 > 🦕