-
Notifications
You must be signed in to change notification settings - Fork 405
enabled langgraph test client use json dump #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gyliu513, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the developer experience when using the langgraph
test client. It modifies the client's output to present responses in a more structured and human-readable JSON format, making it significantly easier to debug and understand the data flow from the client's interactions.
Highlights
- Improved Output Readability: Enhanced the readability of
model_dump
output intest_client.py
by pretty-printing it usingjson.dumps
with an indent of 2, making the JSON responses much easier to inspect. - Enhanced Test Client Clarity: Added descriptive headers and footers (e.g., '=== Send Message Response ===', '=== Multi-turn First Response ===') around the printed JSON responses for various client operations, including
send_message
, multi-turn interactions, and streaming responses. This clearly delineates different outputs. - Streaming Response Tracking: Introduced a chunk counter for streaming responses, printing '--- Chunk X ---' before each streamed JSON chunk, which helps in tracking the progress and individual parts of a streaming interaction.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the readability of the test client's output by pretty-printing the JSON responses. The changes are clear and achieve the stated goal. I've added one comment suggesting a refactoring to reduce code duplication, which would improve the maintainability of the script. Overall, this is a good improvement.
print("=== Send Message Response ===") | ||
print(json.dumps(response.model_dump(mode='json', exclude_none=True), indent=2)) | ||
print("=" * 50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.Fixes #<issue_number_goes_here> 🦕