Skip to content

Conversation

graemefoster
Copy link

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #119

@graemefoster graemefoster requested a review from a team as a code owner June 12, 2025 10:28
@holtskinner
Copy link
Member

Thanks for your contribution! However, this sample is being replaced here: https://github.com/google-a2a/a2a-js/blob/main/src/samples/cli.ts

@swapydapy Can review what you have.

@swapydapy
Copy link
Contributor

The check for currentTaskId and current ContextId is already there when task object is first streamed.
https://github.com/a2aproject/a2a-js/blob/main/src/samples/cli.ts#L304

An Agent is supposed to first send a Task object, and then subsequent task updates.

@graemefoster
Copy link
Author

graemefoster commented Jul 12, 2025

@swapydapy is that documented somewhere? I haven’t looked for a while but felt like the semantics of the protocol are not that obvious - what is sent and when, that sort of thing.

That the message updates contain a task id led me to believe that this was acceptable.

Iirc the examples also don’t (didn’t) make this clear.

@graemefoster
Copy link
Author

@swapydapy see here: https://a2aproject.github.io/A2A/latest/specification/#71-messagesend

no mention that the first message must be a task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants