Skip to content

fix: avoid deprecated urllib3 header helpers - #235

Open
miachillgood wants to merge 3 commits into
XeroAPI:masterfrom
miachillgood:codex/avoid-deprecated-urllib3-header-access
Open

miachillgood wants to merge 3 commits into
XeroAPI:masterfrom
miachillgood:codex/avoid-deprecated-urllib3-header-access

Conversation

@miachillgood

Copy link
Copy Markdown

Summary

  • replace deprecated urllib3 header helper calls in RESTResponse
  • read headers through the response headers mapping instead
  • add a focused unit test for header access

Why

Fixes the deprecation warning reported in #195 when getheader() and getheaders() are called.

Testing

  • python -m pytest tests/test_api_client/test_rest_response.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant