Repository navigation
refactor(frontend): migrate the role and group managers to EntityManagerPage (WI-1940) - #415
Merged
Merged
Conversation
…gerPage (WI-1940) Migrate RoleManager and GroupManager onto the shared scaffold. The scaffold gains an onReady callback that hands the page its reload function, so the group manager's member edits (which live in a separate members modal) can refresh the list the scaffold owns. RoleManager keeps its read-only details modal and translation save outside the scaffold; the scaffold owns the list, the create modal and the delete confirm. GroupManager keeps its members modal and uses dialog-confirm for the create/edit modal to match the existing test. Preserved: role view/delete dropdown actions, group edit/members/delete actions, the is_system guards, the member add/remove confirms, and the ldap/status row cells.
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fourth batch of WI-1940: migrate
RoleManagerandGroupManageronto the sharedEntityManagerPagescaffold.The scaffold gains an
onReadycallback that hands the page itsreloadfunction, so the group manager's member edits (which live in a separate members modal) can refresh the list the scaffold owns.RoleManagerkeeps its read-only details modal and translation save outside the scaffold; the scaffold owns the list, the create modal and the delete confirm.GroupManagerkeeps its members modal and usesdialog-confirmfor the create/edit modal to match the existing test.Behaviour preserved
is_systemguard; group edit/members/delete actions and theis_system_groupguard.workspace-role-submitcreate button, and the inactive-group update payload.Verification
bun run typecheck— 0 errors, 0 warningsbun run check— all guards passcore-testsfrontend suite: 434 files, 3,231 tests, all passgroups(create/edit/delete, add/remove member) passesRemaining follow-ups
EmailTemplateManager,RecurrenceManager,PackManager,IntegrationProviderManager,OAuthClientManager.